Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 276 retire mc 1 google doc #371

Merged
merged 43 commits into from
Jan 8, 2025

Conversation

james-ball-qualcomm
Copy link
Collaborator

Finally merging in improvements to MC100. Now there are 32 & 64 bit versions and MC200 and MC300.

@james-ball-qualcomm
Copy link
Collaborator Author

The smoke test is failing because I added a check in the SymbolTable constructor that the cfg_arch parameter is a ConfiguredArchitecture object. However, your IDL unit-level test uses a MockConfiguredArchitecture class that isn't inherited from anything. How do you want me to fix this? There are many places that check that a cfg_arch parameter is a ConfiguredArchitecture class type.

Note that this is in my oldest PR (#371) that doesn't have the refactored ConfiguredArchitecture (inherited from the new Design class). In my next oldest PR (#386) where the Design class exists, the SymbolTable constructor is passed a MockDesign class which also isn't inherited from anything (but could be inherit from the Design class). So, I'd recommend that we fix this in my later PR since it will be easier to make MockDesign inherit from Design than MockConfiguredArchitecture inherit from ConfiguredArchitecture.

@james-ball-qualcomm
Copy link
Collaborator Author

@dhower-qc, can you please approve this so I don't keep having to merge in other changes from main?

@james-ball-qualcomm james-ball-qualcomm self-assigned this Jan 8, 2025
@james-ball-qualcomm james-ball-qualcomm merged commit 8648c91 into main Jan 8, 2025
10 checks passed
@james-ball-qualcomm james-ball-qualcomm deleted the issue-276-retire-MC-1-Google-Doc branch January 8, 2025 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add remaining items from Google Doc MC-1 to UDB generated MC100
3 participants