-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 276 retire mc 1 google doc #371
Conversation
…ed_instructions which doesn't support this yet.
…erly merge (Sm has no presence or other keys). Enhanced test_inherits_entire_object in yaml loader unit test to reproduce failure.
…e-276-retire-MC-1-Google-Doc
…rate these profiles with some minor bugs found in formating.
…tificates easier to debug.
…clude RVB23 in comparisons with RVA releases.
…compared with the RVA profiles as desired.
… c.not descriptions causing conversion error in Ruby.
…it happens and will need to be fixed).
…endent objects. Also cleaned up some code in obj.rb that seems stale (related to supporting either an Architecture or ConfiguredArchitecture).
The smoke test is failing because I added a check in the SymbolTable constructor that the cfg_arch parameter is a ConfiguredArchitecture object. However, your IDL unit-level test uses a MockConfiguredArchitecture class that isn't inherited from anything. How do you want me to fix this? There are many places that check that a cfg_arch parameter is a ConfiguredArchitecture class type. Note that this is in my oldest PR (#371) that doesn't have the refactored ConfiguredArchitecture (inherited from the new Design class). In my next oldest PR (#386) where the Design class exists, the SymbolTable constructor is passed a MockDesign class which also isn't inherited from anything (but could be inherit from the Design class). So, I'd recommend that we fix this in my later PR since it will be easier to make MockDesign inherit from Design than MockConfiguredArchitecture inherit from ConfiguredArchitecture. |
…a better fix in next PR where the Design class was created.
…/riscv-software-src/riscv-unified-db into issue-276-retire-MC-1-Google-Doc
@dhower-qc, can you please approve this so I don't keep having to merge in other changes from main? |
Finally merging in improvements to MC100. Now there are 32 & 64 bit versions and MC200 and MC300.